diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 4e7583bc49e..6af88454d32 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -53,7 +53,7 @@ jobs: "testmanuals", # test error reporting and compiling as well as libgap - "testexpect testmockpkg testspecial test-compile testlibgap testkernel", + "testexpect testmockpkg testspecial test-compile testlibgap testkernel testworkspace", # compile packages and run GAP tests # don't use --enable-debug to prevent the tests from taking too long diff --git a/Makefile.rules b/Makefile.rules index bd217470454..9bb68d3a6fa 100644 --- a/Makefile.rules +++ b/Makefile.rules @@ -952,7 +952,7 @@ check: all # citests runs a subset of the tests run by CI -- this is SLOW and still doesn't # quite cover everything (e.g. we don't test out-of-tree builds and `make install`) citests: all - SRCDIR=$(abs_srcdir) dev/ci.sh testexpect testmockpkg testspecial test-compile testlibgap testkernel testinstall + SRCDIR=$(abs_srcdir) dev/ci.sh testexpect testmockpkg testspecial test-compile testlibgap testkernel testworkspace testinstall LIBGAPTESTS := $(addprefix tst/testlibgap/,basic api wscreate wsload trycatch) diff --git a/dev/ci.sh b/dev/ci.sh index 0e582497df2..bf7db7a517d 100755 --- a/dev/ci.sh +++ b/dev/ci.sh @@ -353,8 +353,14 @@ GAPInput # if there were any failures, abort now. [[ $TESTMANUALSPASS = yes ]] || error "reference manual tests failed" + ;; + + testworkspace) - # while we are at it, also test the workspace code + # test saving a workspace, with stdin redirected (this tests for an issue + # where we used to disable readline in this case, which lead to issues later + # on when loading the workspace without redirected stdin; for details, + # see https://github.com/gap-system/gap/issues/5014) $GAP -A $(gap_cover_arg workspace) <