This repository has been archived by the owner on Jan 22, 2021. It is now read-only.
Update the Web API after the data/table/tasks refactoring #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytest, ipython, etc. just do: pip install -e ."[dev]" to install these dependencies.
After the data and tasks refactoring, the table names have beed modified. * update some web api unit tests * remove useless functions which were so city-specific
* add two more unit tests
* remove the useless suffix '_route' * some renaming * remove unused variables
* rename 'nom' to 'name' * update the dedicated unit test
delhomer
suggested changes
May 26, 2018
jitenshea/controller.py
Outdated
| ,nb_stations as nb_bikes | ||
| ,st_x(geom) as x | ||
| ,st_y(geom) as y | ||
| FROM {schema}.stations |
There was a problem hiding this comment.
We could recover the stations table name from config file, as in the previous PR.
jitenshea/controller.py
Outdated
| FROM {schema}.daily_transaction AS X | ||
| LEFT JOIN {schema}.{table} AS Y ON X.id=Y.{idcol}::int | ||
| LEFT JOIN {schema}.stations AS Y using(id) |
There was a problem hiding this comment.
Same remark as previously.
jitenshea/controller.py
Outdated
| FROM station AS S | ||
| LEFT JOIN {schema}.daily_transaction AS D ON (S.id=D.id) | ||
| LEFT JOIN {schema}.{table} AS Y ON S.id=Y.{idcol}::int | ||
| LEFT JOIN {schema}.stations AS Y ON S.id=Y.id |
jitenshea/controller.py
Outdated
| query = """SELECT T.* | ||
| ,S.name as name | ||
| FROM {schema}.timeseries AS T | ||
| LEFT JOIN {schema}.stations AS S using(id) |
There was a problem hiding this comment.
Two new occurrences of table names there (timeseries and stations).
jitenshea/controller.py
Outdated
| table, idcol = station_city_table(city) | ||
| query = ("SELECT {id} FROM {schema}.{table}" | ||
| ";").format(id=idcol, schema=config[city]["schema"], table=table) | ||
| query = ("SELECT id FROM {schema}.stations" |
There was a problem hiding this comment.
stations table could be automatized as well.
jitenshea/controller.py
Outdated
| "citystation.geom AS geom, " | ||
| "rank() OVER (ORDER BY stop DESC) AS rank " | ||
| "FROM {schema}.{cluster} AS cs " | ||
| "JOIN {schema}.{table} AS citystation " | ||
| "ON citystation.{idcol} = cs.station_id::varchar " | ||
| "JOIN {schema}.stations AS citystation " |
There was a problem hiding this comment.
Here comes a new occurrence.
|
thanks for the review. I updated the controller.py with your remarks. |
|
Fine for me, ready for merging! |
delhomer
approved these changes
May 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depend on #24