Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to node 21.1.0 #5361

Merged
merged 27 commits into from
Nov 9, 2023
Merged

chore: bump to node 21.1.0 #5361

merged 27 commits into from
Nov 9, 2023

Conversation

TimBeyer
Copy link
Contributor

@TimBeyer TimBeyer commented Nov 7, 2023

What this PR does / why we need it:
Does what it says.

See TypeStrong/ts-node#1997 for the reason for the ts-node change even with esm: true being set.

Which issue(s) this PR fixes:

Closes #4158

Special notes for your reviewer:

@shumailxyz
Copy link
Contributor

This should close issue #4158, right?

@TimBeyer
Copy link
Contributor Author

TimBeyer commented Nov 7, 2023

There's an issue with ts-node which if fixed using the suggested node --experimental-loader=ts-node/esm causes terrible performance for everything run through ts-node.
The performance is so bad, that I wouldn't even consider merging it even if it's just impacting CI script times.

We'd need to either wait for a fix in the project, or maybe see if we can somehow skip running things with ts-node.

@TimBeyer
Copy link
Contributor Author

TimBeyer commented Nov 7, 2023

The new fix seems to be better so I guess we're good to go with this.

Apparently the NPM package name changed; I opened an issue upstream to clarify
because the github repo still links to the old NPM repo.

homebridge/node-pty-prebuilt-multiarch#31
scripts/register-hook.js Outdated Show resolved Hide resolved
@TimBeyer TimBeyer enabled auto-merge November 9, 2023 17:06
Copy link
Member

@stefreak stefreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TimBeyer TimBeyer added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 6097048 Nov 9, 2023
46 checks passed
@TimBeyer TimBeyer deleted the chore/bump-node branch November 9, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Upgrade to Node 20
3 participants