Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

add getTargetMapInfo getTargetName isTargeted getFromTargetInfo #371

Merged
merged 1 commit into from
Oct 8, 2020
Merged

add getTargetMapInfo getTargetName isTargeted getFromTargetInfo #371

merged 1 commit into from
Oct 8, 2020

Conversation

tedteng
Copy link
Contributor

@tedteng tedteng commented Oct 8, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #312

Special notes for your reviewer:

Release note:

Fixed issue that ssh command was not working in case there were shoots with the same name in different projects

@tedteng tedteng requested a review from a team as a code owner October 8, 2020 04:55
@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Oct 8, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 8, 2020
@neo-liang-sap
Copy link
Contributor

Hi @petersutter , could you please take a look at this PR when you have time? i'm not fully involved in discussion between you and @tedteng , thanks!
My understanding of this PR is a increment to #319 (with several fix in infra.go), do correct me if i was wrong.
Generally LGTM
Thanks!
-Neo

@petersutter petersutter self-requested a review October 8, 2020 07:36
petersutter
petersutter approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

please note that I have removed the release note in #319 as this PR was meanwhile reverted and replaced with this PR which includes the same release note. Otherwise the release note would appear twice when releasing.
The release notes handling can't recognize if the changes in PR #319 have been reverted in the meantime, that's why they have to be manually removed from the PR.

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Oct 8, 2020
@neo-liang-sap
Copy link
Contributor

noted with great thanks @petersutter ! i will also take care about this point in future revert occurrence

neo-liang-sap
neo-liang-sap approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@neo-liang-sap neo-liang-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm and merge based on review comments from @petersutter and concourse CI testing results
thanks for the PR

@neo-liang-sap neo-liang-sap merged commit fe62a89 into gardener-attic:master Oct 8, 2020
@tedteng tedteng deleted the new1111 branch October 12, 2020 02:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neo-liang-sap neo-liang-sap neo-liang-sap approved these changes

@petersutter petersutter petersutter approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gardenctl ssh fails when targeting a non unique shoot name
5 participants
@tedteng @neo-liang-sap @petersutter @gardener-robot-ci-3 @gardener-robot