Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix-1.50] Support http response content compression #1027

Merged
merged 2 commits into from
May 27, 2021
Merged

[hotfix-1.50] Support http response content compression #1027

merged 2 commits into from
May 27, 2021

Conversation

holgerkoser
Copy link
Member

@holgerkoser holgerkoser commented May 27, 2021 •
edited
Loading

What this PR does / why we need it:
With this PR the http/2 request library supports content compression. This can improve the performance for large responses by a factor of 10. This regression has been introduced with release 1.50.0

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Improves performance by implementing support for http response content compression. This regression has been introduced with release 1.50.0

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels May 27, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 27, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 27, 2021
petersutter
petersutter approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 27, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 27, 2021
@holgerkoser holgerkoser merged commit a981c58 into hotfix-1.50 May 27, 2021
@holgerkoser holgerkoser deleted the bug/content-encoding branch May 27, 2021 09:13
@holgerkoser holgerkoser changed the title Support http response content compression [hotfix-1.50] Support http response content compression May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@grolu grolu Awaiting requested review from grolu

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@holgerkoser @petersutter @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot