Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep frontend host during the OIDC login process #1054

Merged
merged 9 commits into from
Jul 9, 2021
Merged

Keep frontend host during the OIDC login process #1054

merged 9 commits into from
Jul 9, 2021

Conversation

holgerkoser
Copy link
Member

@holgerkoser holgerkoser commented Jul 1, 2021 •
edited by petersutter
Loading

What this PR does / why we need it:
This PR adds full support for all hostnames configured in the dashboard ingress. This means that all hostnames are valid OIDC redirect URIs. The configuration property .Values.oidc.redirectUri is no longer used and has been removed. The list of valid OIDC redirect URIs is determined based on the ingress configuration.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Preserve the initial URL hostname during the OIDC login process 

Please note the following changes in the `values.yaml` file of the `gardener-dashboard` helm chart:
- The configuration property `.Values.oidc.redirectUri` is no longer used and has been removed. Instead, the list of valid OIDC redirect URIs is determined based on the ingress hosts `.Values.ingress.hosts`. If tls `.Values.ingress.tls` is active the redirect URI scheme is assumed to be `https` for all hosts.

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jul 1, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 1, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 1, 2021
petersutter
petersutter approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 1, 2021
@gardener-robot
Copy link

@grolu You have pull request review open invite, please check

@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) reviewed/lgtm Has approval for merging labels Jul 7, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 7, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 7, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 8, 2021
@petersutter petersutter self-requested a review July 8, 2021 13:19
petersutter
petersutter approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Jul 8, 2021
grolu
grolu approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@holgerkoser holgerkoser merged commit e83681b into master Jul 9, 2021
@holgerkoser holgerkoser deleted the enh/redirect-uri branch July 9, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grolu grolu grolu approved these changes

@petersutter petersutter petersutter approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@holgerkoser @gardener-robot @petersutter @grolu @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3