Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh accessToken of gcp auth-provider user #1058

Merged
merged 4 commits into from
Jul 15, 2021
Merged

Refresh accessToken of gcp auth-provider user #1058

merged 4 commits into from
Jul 15, 2021

Conversation

holgerkoser
Copy link
Member

@holgerkoser holgerkoser commented Jul 8, 2021 •
edited
Loading

What this PR does / why we need it:
This PR allows the usage of gcp auth-provider in kubeconfig secrets. If there is a property named serviceaccount.json next to the kubeconfig property the access-token is refreshed using these credentials.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Added support to authenticate against GKE clusters using google service account key. In this case, the referenced secret needs to have the `serviceaccount.json` data key in addition to the `kubeconfig` data key

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jul 8, 2021
@holgerkoser holgerkoser marked this pull request as draft July 8, 2021 16:33
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 8, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 8, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 8, 2021
@petersutter
Copy link
Member

cc @mliepold

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 9, 2021
@holgerkoser holgerkoser marked this pull request as ready for review July 9, 2021 10:42
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 9, 2021
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jul 9, 2021
@gardener-robot
Copy link

@grolu You have pull request review open invite, please check

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 12, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 12, 2021
petersutter
petersutter approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jul 15, 2021
grolu
grolu approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@holgerkoser holgerkoser merged commit 5166b32 into master Jul 15, 2021
@holgerkoser holgerkoser deleted the enh/auth-provider-gcp branch July 15, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grolu grolu grolu approved these changes

@petersutter petersutter petersutter approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@holgerkoser @petersutter @gardener-robot @grolu @gardener-robot-ci-2 @gardener-robot-ci-3