Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Do not show scrollbars when there is enough space. #1087

Merged
merged 2 commits into from
Aug 17, 2021
Merged

[master] Do not show scrollbars when there is enough space. #1087

merged 2 commits into from
Aug 17, 2021

Conversation

holgerkoser
Copy link
Member

What this PR does / why we need it:
Fixes the problem that scroll bars are displayed in the UI even if there is enough space available

Which issue(s) this PR fixes:
Fixes #1085

Special notes for your reviewer:

Release note:

Fixes the problem that scroll bars are displayed in the UI even if there is enough space available.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 12, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 12, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 12, 2021
@holgerkoser holgerkoser mentioned this pull request Aug 12, 2021
Closed
@gardener-robot
Copy link

@grolu You have pull request review open invite, please check

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 17, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 17, 2021
grolu
grolu approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 17, 2021
@holgerkoser
Copy link
Member Author

/lgtm

@holgerkoser holgerkoser merged commit 540a8ca into master Aug 17, 2021
@holgerkoser holgerkoser deleted the fix/issue-1085 branch August 17, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grolu grolu grolu approved these changes

@petersutter petersutter Awaiting requested review from petersutter petersutter is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Scrollbars in WebUI
6 participants
@holgerkoser @gardener-robot @grolu @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3