Detect Dark Mode Settings #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
petersutter
reviewed
Mar 18, 2021
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
holgerkoser
reviewed
Mar 19, 2021
frontend/src/store/index.js
Outdated
| state.darkMode = value | ||
| localStorage.setItem('global/dark-mode', value) | ||
| Vue.vuetify.framework.theme.dark = value | ||
| if (value !== undefined) { |
There was a problem hiding this comment.
From my point of view this is an antipattern. A mutation should only mutate the store state and not run mediaqueries. The new value must come from outside the mutation.
There was a problem hiding this comment.
We should start using store plugins for this kind of problems.
export default function createMediaPlugin (window) {
return store => {
const colorScheme = window.localStorage.getItem('global/color-scheme')
store.commit('SET_COLOR_SCHEME', colorScheme)
const mq = window.matchMedia('(prefers-color-scheme: dark)')
switch (store.state.coloScheme) {
case 'dark':
store.commit('SET_DARK_THEME', true)
break
case 'light':
store.commit('SET_DARK_THEME', false)
break
default:
store.commit('SET_DARK_THEME', mq.matches)
break
}
mq.addEventListener(e => {
if (!['dark', 'light'].includes(store.state.coloScheme)) {
store.commit('SET_DARK_THEME', e.matches)
}
})
}
}
holgerkoser
reviewed
Mar 19, 2021
frontend/src/app.js
Outdated
| @@ -21,8 +21,13 @@ const App = Vue.extend({ | |||
| } | |||
| }) | |||
|
|
|||
| const darkMode = this.$localStorage.getItem('global/dark-mode') === 'true' | |||
| const darkMode = this.$localStorage.getItem('global/setting-dark-mode') || 2 | |||
There was a problem hiding this comment.
Why global/seeting-dark-mode and not global/dark-mode or global/settings/dark-mode?
There was a problem hiding this comment.
I would propose to have a localStorage porperty 'global/color-scheme' or 'global/settings/color-scheme' with possible values dark, light and any other value means use system settings
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
size/m
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-3
added
reviewed/ok-to-test
petersutter
reviewed
Mar 19, 2021
petersutter
reviewed
Mar 19, 2021
Comment on lines
+227
to
+245
| return 0 | ||
| case 'dark': | ||
| return 1 | ||
| default: | ||
| return 2 | ||
| } | ||
| }, | ||
| set (value) { | ||
| this.setDarkMode(value) | ||
| switch (value) { | ||
| case 0: | ||
| this.setColorScheme('light') | ||
| break | ||
| case 1: | ||
| this.setColorScheme('dark') | ||
| break | ||
| default: | ||
| this.setColorScheme('auto') | ||
| break | ||
| } |
There was a problem hiding this comment.
use constants instead of magic/index numbers
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Co-authored-by: Peter Sutter <peter.sutter@sap.com>
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With this PR the Dashboard can detect the system settings for dark mode
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: