Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set correct terminal controller sidecar image replacement #533

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Set correct terminal controller sidecar image replacement #533

merged 1 commit into from
Jun 17, 2021

Conversation

einfachnuralex
Copy link
Contributor

What this PR does / why we need it:
The terminal controller sidecar kube-rbac-proxy image has changed and will not get replaced with acre versions. So image to be replaced is changed to quay.io/brancz/kube-rbac-proxy.

Release note:

Sidecar image for terminal controller can be replaced through acre versions.

@einfachnuralex einfachnuralex requested a review from a team as a code owner June 17, 2021 13:35
Diaphteiros
Diaphteiros approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@Diaphteiros Diaphteiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

@gardener-robot
Copy link

@einfachnuralex Thank you for your contribution.

@Diaphteiros Diaphteiros merged commit 33e5da9 into gardener:master Jun 17, 2021
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Jun 17, 2021
@einfachnuralex einfachnuralex deleted the feature/terminal-rbac-proxy-overwrite branch June 17, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Diaphteiros Diaphteiros Diaphteiros approved these changes

Assignees
No one assigned
Labels
size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@einfachnuralex @gardener-robot @Diaphteiros