Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Readme #873

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Update Readme #873

merged 3 commits into from
Sep 1, 2022

Conversation

jguipi
Copy link
Contributor

@jguipi jguipi commented Aug 17, 2022

What this PR does / why we need it:

  • Adding information on how to use a SA in the kubeconfig. It was not necessarily clear how to replace the basic authentication method.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Release note:

- Adding information on how to use a SA in the kubeconfig. I

jguipi added 2 commits August 17, 2022 15:28
@jguipi
Update README.md
fb9ee18 
Adding how to use a SA in the kubeconfig
@jguipi
Merge pull request #1 from jguipi/jguipi-patch-1
01fe9ed 
Update README.md
@jguipi jguipi requested a review from a team as a code owner August 17, 2022 19:31
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 17, 2022
Diaphteiros
Diaphteiros requested changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@Diaphteiros Diaphteiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just fix the link and I'll merge it.

README.md Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Aug 18, 2022
@jguipi
Copy link
Contributor Author

jguipi commented Aug 18, 2022

Nice! Just fix the link and I'll merge it.

I updated it !
thx !

@jguipi jguipi requested a review from Diaphteiros August 22, 2022 14:19
@jguipi
Copy link
Contributor Author

jguipi commented Aug 31, 2022

cc.: @Diaphteiros

Diaphteiros
Diaphteiros approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@Diaphteiros Diaphteiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Sep 1, 2022
@Diaphteiros Diaphteiros merged commit 413b2a0 into gardener:master Sep 1, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Diaphteiros Diaphteiros Diaphteiros approved these changes

Assignees
No one assigned
Labels
reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jguipi @Diaphteiros @gardener-robot