Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the provider type predicates in webhooks #1117

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Remove the provider type predicates in webhooks #1117

merged 1 commit into from
Nov 11, 2024

Conversation

LucaBernstein
Copy link
Member

How to categorize this PR?

/area usability
/kind cleanup
/platform aws

What this PR does / why we need it:
Cleanup the duplicate check for an object's provider type.

Which issue(s) this PR fixes:
Part of gardener/gardener#10745

Special notes for your reviewer:
/cc @timuthy

Release note:

Remove the duplicate provider type check from the admission webhooks.

@LucaBernstein LucaBernstein requested review from a team as code owners November 4, 2024 12:04
@gardener-robot gardener-robot added needs/review Needs review area/usability Usability related kind/cleanup Something that is not needed anymore and can be cleaned up platform/aws Amazon web services platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 4, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 4, 2024
@LucaBernstein LucaBernstein mentioned this pull request Nov 4, 2024
Open
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 4, 2024
@LucaBernstein LucaBernstein force-pushed the 10745-cleanup-provider-type-predicates branch from 55c51d9 to 7e54105 Compare November 4, 2024 12:07
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 4, 2024
timuthy
timuthy reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-robot
Copy link

@timuthy Command /approve is not known.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 7, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 7, 2024
AndreasBurger
AndreasBurger approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AndreasBurger AndreasBurger merged commit 8631685 into gardener:master Nov 11, 2024
13 checks passed
@LucaBernstein LucaBernstein deleted the 10745-cleanup-provider-type-predicates branch November 11, 2024 14:47
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 11, 2024
@LucaBernstein LucaBernstein restored the 10745-cleanup-provider-type-predicates branch November 12, 2024 13:46
@LucaBernstein LucaBernstein deleted the 10745-cleanup-provider-type-predicates branch November 15, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timuthy timuthy timuthy left review comments

@AndreasBurger AndreasBurger AndreasBurger approved these changes

Assignees
No one assigned
Labels
area/usability Usability related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LucaBernstein @gardener-robot @AndreasBurger @timuthy @gardener-robot-ci-1