Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release v1.8] Retain fault and update domain counts #112

Merged
merged 2 commits into from
Jun 17, 2020
Merged

[Release v1.8] Retain fault and update domain counts #112

merged 2 commits into from
Jun 17, 2020

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Jun 17, 2020

How to categorize this PR?

/area quality
/kind bug
/priority normal
/platform azure

What this PR does / why we need it:
Backport of #111

Release note:

An issue has been fixed which caused a reconcile error for the infrastructure if the `countFaultDomains` or `countUpdateDomains` values for the shoot's region was changed.

@timuthy timuthy requested review from a team as code owners June 17, 2020 07:36
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug platform/azure Microsoft Azure platform/infrastructure priority/normal labels Jun 17, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 17, 2020
rfranzke
rfranzke approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Jun 17, 2020
@rfranzke rfranzke merged commit 1dce975 into gardener:release-v1.8 Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timuthy @rfranzke @gardener-robot-ci-1 @gardener-robot