-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure remedy controller resources have been deleted #138
Ensure remedy controller resources have been deleted #138
Conversation
Thank you @stoyanr for your contribution. I will start a build for your PR. Once started, the build URL will be posted here. |
A build of this pull request has started. You can check on its progress here: https://concourse.ci.gardener.cloud/teams/gardener/pipelines/gardener-extension-provider-azure-master/jobs/master-pull-request-job/builds/3 |
71c920e
to
4a95d03
Compare
Thank you @stoyanr for updating the PR. I will start a build. Once started, the build URL will be posted here. |
A build of this pull request has started. You can check on its progress here: https://concourse.ci.gardener.cloud/teams/gardener/pipelines/gardener-extension-provider-azure-master/jobs/master-pull-request-job/builds/4 |
So if I understand this correctly, part of the Remedy Controller is now vendored in here so that we can enhance the extension-provider to also clean up after the Remedy Controller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks great, no suggestions. Do you want to add some unit test for the deletion?
@AndreasBurger The components are not coupled, or rather, what you mean with "coupled" is already in place without this PR. The Azure extension deploys the Azure remedy controller already with a specific version and a specific deployment manifest, so it already has knowledge about what the remedy controller will do. |
4a95d03
to
531be59
Compare
Thank you @stoyanr for updating the PR. I will start a build. Once started, the build URL will be posted here. |
A build of this pull request has started. You can check on its progress here: https://concourse.ci.gardener.cloud/teams/gardener/pipelines/gardener-extension-provider-azure-master/jobs/master-pull-request-job/builds/5 |
531be59
to
23ff868
Compare
Thank you @stoyanr for updating the PR. I will start a build. Once started, the build URL will be posted here. |
A build of this pull request has started. You can check on its progress here: https://concourse.ci.gardener.cloud/teams/gardener/pipelines/gardener-extension-provider-azure-master/jobs/master-pull-request-job/builds/6 |
@rfranzke To add unit tests, I need to generate mocks for the |
20e117b
to
ee79e86
Compare
Rebased on top of #141, dependency to https://github.com/stoyanr/gardener removed. |
ee79e86
to
e3ba364
Compare
e3ba364
to
deb29e7
Compare
Rebased on top of master and removed "draft". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/needs rebase |
deb29e7
to
59fff49
Compare
How to categorize this PR?
/area control-plane
/kind enhancement
/priority normal
/platform azure
What this PR does / why we need it:
Ensures that all remaining remedy controller resources have been deleted before deleting the remedy controller itself.
Which issue(s) this PR fixes:
Fixes gardener/remedy-controller#32
Special notes for your reviewer:
Release note: