Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate worker-configuration in machine deployment #144

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Populate worker-configuration in machine deployment #144

merged 1 commit into from
Aug 4, 2020

Conversation

hardikdr
Copy link
Member

@hardikdr hardikdr commented Aug 4, 2020 •
edited by rfranzke
Loading

How to categorize this PR?

/area usability
/kind enhancement
/priority normal
/platform azure

What this PR does / why we need it: This PR populates the controller-configurations on the machine-deployment from worker-object.

Which issue(s) this PR fixes:
Fixes #136

Special notes for your reviewer:
The following dependencies need to be resolved.

Release note:

Worker extension allows configuring following parameters on machine-deployment: drainTimeout, creationTimeout, healthTimeout, maxEvictRetries, nodeConditions.

@hardikdr hardikdr requested review from a team as code owners August 4, 2020 05:49
@gardener-robot gardener-robot added area/usability Usability related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure priority/normal labels Aug 4, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 4, 2020
@hardikdr
Copy link
Member Author

hardikdr commented Aug 4, 2020

Copy of the PR for AWS: gardener/gardener-extension-provider-aws#149 .

@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 4, 2020
@hardikdr hardikdr force-pushed the feature/mcm-config branch from 7c15027 to 1521bd4 Compare August 4, 2020 06:05
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 4, 2020
rfranzke
rfranzke approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Aug 4, 2020
@rfranzke rfranzke merged commit 255a61a into gardener:master Aug 4, 2020
@gardener-robot gardener-robot added the priority/3 Priority (lower number equals higher priority) label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure priority/3 Priority (lower number equals higher priority) reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure mcm-settings from worker to machine-deployment.
6 participants
@hardikdr @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot