Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not delete csi-snapshot-validation ClusterRole and ClusterRoleBinding from the wrong cluster (Seed cluster) when deleting Shoot #664

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Do not delete csi-snapshot-validation ClusterRole and ClusterRoleBinding from the wrong cluster (Seed cluster) when deleting Shoot #664

merged 1 commit into from
Apr 10, 2023

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area quality
/kind bug
/kind regression
/platform azure

What this PR does / why we need it:
Similar to gardener/gardener-extension-provider-aws#735

Which issue(s) this PR fixes:
See above

Special notes for your reviewer:
N/A

Release note:

An issue causing provider-azure to wrongly delete the `extensions.gardener.cloud:provider-azure:csi-snapshot-validation` ClusterRole and ClusterRoleBinding from the Seed cluster on every Shoot deletion is now fixed.

@ialidzhikov
Do not delete csi-snapshot-validation ClusterRole and ClusterRoleBi…
48ab9f8 
…nding from the wrong cluster (Seed cluster) when deleting Shoot
@ialidzhikov ialidzhikov requested review from a team as code owners April 7, 2023 13:31
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 7, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 7, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 7, 2023
@ialidzhikov ialidzhikov mentioned this pull request Apr 7, 2023
Closed
kon-angelo
kon-angelo approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 10, 2023
@kon-angelo kon-angelo added this to the v1.35 milestone Apr 10, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 10, 2023
@kon-angelo kon-angelo merged commit 634f20c into gardener:master Apr 10, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 10, 2023
@ialidzhikov ialidzhikov deleted the fix/csi-snapshot-validation-rbac branch May 16, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v1.35
Development

Successfully merging this pull request may close these issues.
6 participants
@ialidzhikov @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot