-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix restoration of infra with migrated network layout #907
base: master
Are you sure you want to change the base?
Conversation
@plkokanov You need rebase this pull request with latest master branch. Please check. |
8143a4d
to
e149789
Compare
/hold |
I finally have time to come back to this and I have done the following tests all of which passed without issues:
@kon-angelo, does it make sense to preform similar tests when migrating the control plane from a seed that uses the In the tests above, would it make a difference if the annotation used to enable the |
bba2a25
to
7ed9eae
Compare
/unhold |
7ed9eae
to
0e94603
Compare
How to categorize this PR?
/area control-plane-migration
/kind bug
/platform azure
What this PR does / why we need it:
This PR modifies the layout mutator which adds the
migration.azure.provider.extensions.gardener.cloud/zone
annotation on theInfrastructure
resource so that the annotation is also added during therestore
phase of control plane migration in the following cases:.status.state
field is defined and is in theazure.provider.extensions.gardener.cloud/v1alpha1
group version, then.data
field contains an entry formigration.azure.provider.extensions.gardener.cloud/zone
, then this entry is added as an annotation to theInfrastructure
resource.status.state
field is defined and its type isInfrastructureState
, then.state
field contains a.savedProviderStatus
field and its.networks.subnets
array contains a subnet for which the.migrated
field is true and the.zone
field is not nilAdditionally, during reconciliation, if the new flow reconciler is used and the
migration.azure.provider.extensions.gardener.cloud/zone
annotation is present on theInfrastructure
resource, then it is persisted in the.status.state.data
map.Which issue(s) this PR fixes:
Fixes #827
Special notes for your reviewer:
Release note: