Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release v1.47] Infer cloud instance from bucket region when possible #947

Merged
merged 1 commit into from
Aug 21, 2024
Merged

[Release v1.47] Infer cloud instance from bucket region when possible #947

merged 1 commit into from
Aug 21, 2024

Conversation

AndreasBurger
Copy link
Member

How to categorize this PR?

/area backup
/kind enhancement
/platform azure

What this PR does / why we need it:
The storage domain to use for backup buckets will now be inferred from the buckets' region if no explicit config is given. This is consistent with how the rest of our codebase does it.

Release note:

The storage domain to use for backup buckets is now inferred from the buckets' region if no explicit config is given

@AndreasBurger
also infer cloud instance from bucket region when possible
3e56791 
make behaviour consistent with the rest of the code. Also
update/fix docstrings
@AndreasBurger AndreasBurger requested review from a team as code owners August 21, 2024 09:34
@gardener-robot gardener-robot added the needs/review Needs review label Aug 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 21, 2024
@gardener-robot gardener-robot added area/backup Backup related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 21, 2024
hebelsan
hebelsan approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 21, 2024
@AndreasBurger AndreasBurger merged commit 03fe0be into gardener:release-v1.47 Aug 21, 2024
19 checks passed
@AndreasBurger AndreasBurger deleted the cc-fix branch August 21, 2024 13:08
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hebelsan hebelsan hebelsan approved these changes

Assignees
No one assigned
Labels
area/backup Backup related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreasBurger @hebelsan @gardener-robot-ci-1 @gardener-robot