Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove min/maxAllowed #973

Merged
merged 2 commits into from
Sep 30, 2024
Merged

remove min/maxAllowed #973

merged 2 commits into from
Sep 30, 2024

Conversation

AndreasBurger
Copy link
Member

How to categorize this PR?

/area control-plane
/kind enhancement
/platform azure

What this PR does / why we need it:
Remove VPA (min|max)Allowed settings.

minAllowed may cause wasted resources while maxAllowed may cause under-reservation and hence noisy neighbor issues.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The provider-azure extension no longer configures min/maxAllowed in any managed VPA resource.

@AndreasBurger AndreasBurger requested review from a team as code owners September 27, 2024 13:16
@gardener-robot gardener-robot added the needs/review Needs review label Sep 27, 2024
@CLAassistant
Copy link

CLAassistant commented Sep 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 27, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 27, 2024
@kon-angelo
Copy link
Contributor

/cla

@gardener-robot
Copy link

@kon-angelo I reached out successfully to the cla-assistant to recheck this pull request.

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Sep 27, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 27, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2024
kon-angelo
kon-angelo approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit e9bcf8a into master Sep 30, 2024
10 checks passed
@kon-angelo kon-angelo deleted the rm-min-max-allowed branch September 30, 2024 13:21
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes labels Sep 30, 2024
@gardener-robot gardener-robot added status/closed Issue is closed (either delivered or triaged) and removed needs/review Needs review labels Sep 30, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AndreasBurger @CLAassistant @kon-angelo @gardener-robot @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3