Periodically rotate etcd storage account secret #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/security
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
AndreasBurger
force-pushed
the
rotate-etcd-credentials
branch
from
519a744 to
33be110
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
AndreasBurger
force-pushed
the
rotate-etcd-credentials
branch
from
33be110 to
afe351d
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
AndreasBurger
force-pushed
the
rotate-etcd-credentials
branch
from
afe351d to
5ae1574
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
AndreasBurger
force-pushed
the
rotate-etcd-credentials
branch
from
5ae1574 to
9f42b83
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
Some small last-minute changes, nothing functional so good to review. Will run another final test after reviews are done. |
hebelsan
reviewed
Nov 4, 2024
| response, err := c.client.ListKeys(ctx, resourceGroupName, storageAccountName, &armstorage.AccountsClientListKeysOptions{ | ||
| // doc: "Specifies type of the key to be listed. Possible value is kerb.. Specifying any value will set the value to kerb." | ||
| Expand: ptr.To("kerb"), | ||
| }) | ||
|
|
||
| if err != nil { | ||
| return "", err | ||
| return nil, err | ||
| } | ||
|
|
||
| if len(response.Keys) < 1 { |
There was a problem hiding this comment.
Just a nit: but don't we expect the Keys to have a length of 2?
kon-angelo
reviewed
Nov 7, 2024
| @@ -64,3 +75,7 @@ func (a *actuator) getBackupBucketGeneratedSecret(ctx context.Context, backupBuc | |||
| } | |||
| return secret, nil | |||
| } | |||
|
|
|||
| func shouldBeRotated(secret corev1.Secret) (bool, error) { | |||
| return secret.CreationTimestamp.Time.Before(time.Now().AddDate(0, 0, -14)), nil | |||
There was a problem hiding this comment.
Can we make this configurable ?
|
@AndreasBurger You need rebase this pull request with latest master branch. Please check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area security
/kind enhancement
/platform azure
What this PR does / why we need it:
Rotate the key used to authenticate with the storage account for etcd-backups periodically.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: