Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose MCM logs to the end-users #319

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Expose MCM logs to the end-users #319

merged 1 commit into from
Jul 22, 2021
+7 −1

Conversation

vlvasilev
Copy link
Contributor

@vlvasilev vlvasilev commented Jul 21, 2021 •
edited
Loading

How to categorize this PR?

/area logging
/kind enhancement
/platform openstack

What this PR does / why we need it:
With this PR we allow end-users to see the MCM logs.
The logs will be visible after the merge of g/g#4387

Which issue(s) this PR fixes:
Рartially fixes g/g#4340

Special notes for your reviewer:

Release note:

machine-controller-manager logs are exposed to the end-users

@vlvasilev vlvasilev requested review from a team as code owners July 21, 2021 16:27
@gardener-robot
Copy link

@vlvasilev Labels area/todo, kind/todo do not exist.

@gardener-robot gardener-robot added platform/openstack OpenStack platform/infrastructure needs/rebase Needs git rebase labels Jul 21, 2021
@gardener-robot
Copy link

@vlvasilev You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 21, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 21, 2021
@gardener-robot gardener-robot added area/logging Logging related kind/enhancement Enhancement, improvement, extension labels Jul 21, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 21, 2021
@vlvasilev vlvasilev force-pushed the expose-MCM-logs-to-the-end-user branch from f26e4e8 to 2aa048a Compare July 21, 2021 16:33
@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Jul 21, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 21, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 21, 2021
dkistner
dkistner approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 22, 2021
@dkistner dkistner merged commit b26604c into gardener:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

Assignees
No one assigned
Labels
area/logging Logging related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose logs of machine-controller-manager to end users
6 participants
@vlvasilev @gardener-robot @dkistner @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3