Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation of Kubernetes feature gates #161

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Add validation of Kubernetes feature gates #161

merged 2 commits into from
Jun 11, 2021

Conversation

stoyanr
Copy link
Contributor

@stoyanr stoyanr commented Jun 10, 2021

How to categorize this PR?

/area usability
/area ops-productivity
/kind enhancement
/platform vsphere

What this PR does / why we need it:
Adds validation of Kubernetes feature gates (in CloudControllerManager field of the ControlPlaneConfig custom resource), as requested in gardener/gardener#3987 and gardener/gardener-extension-provider-gcp#263. Similar to gardener/gardener-extension-provider-gcp#280 but for vsphere.

Which issue(s) this PR fixes:
Fixes gardener/gardener-extension-provider-gcp#263 for vsphere.

Special notes for your reviewer:

  • Also vendors g/g v1.24.1-0.20210608063816-580010846480 to be able to use the ValidateFeatureGates function.

Release note:

When creating or updating shoots, any Kubernetes feature gates mentioned are validated against the Kubernetes version. If any feature gates are unknown or not supported in the Kubernetes version, the validation fails.

@stoyanr stoyanr requested review from a team as code owners June 10, 2021 13:27
@gardener-robot gardener-robot added area/ops-productivity Operator productivity related (how to improve operations) area/usability Usability related kind/enhancement Enhancement, improvement, extension platform/vsphere VMware vSphere platform/infrastructure needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jun 10, 2021
@stoyanr
Copy link
Contributor Author

stoyanr commented Jun 10, 2021

/invite @rfranzke @ialidzhikov @MartinWeindel

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 10, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 10, 2021
@stoyanr stoyanr force-pushed the add-feature-gates-validation branch from 3e09a4f to ef9124f Compare June 10, 2021 13:36
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 10, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 10, 2021
MartinWeindel
MartinWeindel approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
smoke test on dev environment was successful

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 11, 2021
@MartinWeindel MartinWeindel merged commit 7c707dc into gardener:master Jun 11, 2021
@stoyanr stoyanr deleted the add-feature-gates-validation branch June 14, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

@rfranzke rfranzke Awaiting requested review from rfranzke

Assignees
No one assigned
Labels
area/ops-productivity Operator productivity related (how to improve operations) area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/vsphere VMware vSphere platform/infrastructure reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ControllerManager Feature Gate CustomResourceValidation no longer exists
6 participants
@stoyanr @MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot