Introduce delay in re-enqueuing machines during creation--deletion failures. #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-3
added
the
reviewed/ok-to-test
|
/hold - Need to adapt tests. |
gardener-robot
added
the
reviewed/do-not-merge
gardener-robot-ci-3
added
needs/ok-to-test
prashanth26
reviewed
Oct 1, 2020
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
hardikdr
force-pushed
the
throttle-api-calls
branch
from
c8c663b to
080809a
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
|
Update: We decided to merge these changes on master-branch first, and hotfix it here only if we see a need later. |
hardikdr
force-pushed
the
throttle-api-calls
branch
from
080809a to
99e262a
Compare
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
…n and deletion failures Co-authored-by: Prashanth <prashanth@sap.com>
hardikdr
force-pushed
the
throttle-api-calls
branch
from
99e262a to
b725343
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
|
/unhold |
gardener-robot
removed
the
reviewed/do-not-merge
prashanth26
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Prashanth prashanth@sap.com
What this PR does / why we need it: Currently we immediately re-enqueue the machine-object on creation/deletion failure. This PR adds a constant delay before retrying the operation. Eventually, we must build exponential retry on top or parallel to this solution.
CrashLoopBackOff. This should be used when machine creation fails, but machine-set doesn't really need to replace the machine-object[as that won't anyways help].Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: