-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale-up only new machineSet while scale-down all active mSs proportionally #765
Merged
himanshu-kun
merged 4 commits into
gardener:master
from
himanshu-kun:scale-only-new-machineset
Jan 23, 2023
Merged
Scale-up only new machineSet while scale-down all active mSs proportionally #765
himanshu-kun
merged 4 commits into
gardener:master
from
himanshu-kun:scale-only-new-machineset
Jan 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
Needs review
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
labels
Jan 9, 2023
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jan 9, 2023
ran the IT tests. running fine. |
himanshu-kun
force-pushed
the
scale-only-new-machineset
branch
from
January 10, 2023 13:15
79f9dca
to
7a2d6cb
Compare
gardener-robot
added
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
and removed
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
labels
Jan 10, 2023
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jan 10, 2023
@rishabh-11 You have pull request review open invite, please check |
unmarshall
reviewed
Jan 20, 2023
gardener-robot
added
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
and removed
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
labels
Jan 23, 2023
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jan 23, 2023
Co-authored-by: Madhav Bhargava <madhav.bhargava@sap.com>
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jan 23, 2023
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jan 23, 2023
unmarshall
approved these changes
Jan 23, 2023
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
Jan 23, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/review
Needs review
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR changes the scaling logic of machineDeployment.
#Before
a scale-up or scale-down lead to proportional splitting of the increase/decrease in replicas among the machineSets as per their size
#Now
a scale-up leads to increase in replicas of the new machineSet only, while scale-down leads to the same proportional scaling as before.
This is done keeping in mind working of autoscaler with MCM. Because during rolling update if autoscaler asked for a scale-up , it used to add machine to the old machineSet(s) during the initial phases of the rolling update. This was inefficient as that machine would be drained later leading to longer rolling update cycle.
Which issue(s) this PR fixes:
Fixes #754
Special notes for your reviewer:
The change is made keeping autoscaler interaction with MCM in mind. Corresponding PR on autoscaler is also raised, to stop autoscaler from scaling down during rolling update operations.
Release note: