Introduce a feature to propagate the machine name to user data and as label to the node #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
rishabh-11
requested changes
Jun 27, 2024
There was a problem hiding this comment.
Can you also move the code in pkg/util/provider/machinecontroller/machine_name.go and pkg/util/provider/machinecontroller/machine_bootstrap_token.go into a new file called userdata.go at pkg/util/provider/machinecontroller/? This way we have all the userdata related code in one place and can add more code in it if required in the future instead of creating new files everytime
gardener-robot
added
size/m
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
|
Thanks for reviewing. I just applied your feedback. |
rishabh-11
requested changes
Jul 2, 2024
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot
removed
needs/changes
gardener-robot-ci-3
added
the
reviewed/ok-to-test
rishabh-11
requested changes
Jul 4, 2024
elankath
reviewed
Jul 4, 2024
elankath
reviewed
Jul 4, 2024
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds two new features to MCM which are required to enable
node-agent-authorizerwebhook based authentication forgardener-node-agent. Please see gardener/gardener#10014<<MACHINE_NAME>>in user data with the name of the machine when it is bootstrapped.node.gardener.cloud/machine-namelabel of the corresponding node.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:
MCM replaces the magic string `<<MACHINE_NAME>>` in user data with the name of the machine when it is bootstrapped.