Solves runtime deployment issue at the helm chart. hostNetwork
was not set.
#117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I am testing the chart locally (using kind). And I found the deployment didn't expose the port as a host port.
This is required to let the
api-server
reach this pod to authenticate requests.I guess this was forgotten as the
deployment
available underconfig/samples
have it: https://github.com/gardener/oidc-webhook-authenticator/blob/master/config/samples/deployment.yaml#L90Which issue(s) this PR fixes:
Not opened yet, i can open one if it is required.
Special notes for your reviewer:
Im writing some docs to demonstrate how to make it working on a
kind
(locally) k8s cluster. Let me know if you want to publish it somewhere :)Release note: