From f49fe0b6a55407f13a3af23abe3ac489794606fe Mon Sep 17 00:00:00 2001 From: Jarmo Isotalo Date: Tue, 10 Nov 2020 10:09:16 +0200 Subject: [PATCH] chore(telemery): ensure plugin validation errors are captured (#27933) * Try to capture errors * Log to stdout so that in debug mode these error won't trigger a reporter error infinite loop * Clarify terms --- packages/gatsby-cli/src/reporter/reporter.ts | 1 + packages/gatsby-telemetry/src/event-storage.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/gatsby-cli/src/reporter/reporter.ts b/packages/gatsby-cli/src/reporter/reporter.ts index 7a90aa6b72b1e..dfdbc866399a2 100644 --- a/packages/gatsby-cli/src/reporter/reporter.ts +++ b/packages/gatsby-cli/src/reporter/reporter.ts @@ -158,6 +158,7 @@ class Reporter { if (structuredError) { reporterActions.createLog(structuredError) + trackError(`GENERIC_ERROR`, { error: structuredError }) } // TODO: remove this once Error component can render this info diff --git a/packages/gatsby-telemetry/src/event-storage.ts b/packages/gatsby-telemetry/src/event-storage.ts index e50d77fa3d874..177dd6fe3e9aa 100644 --- a/packages/gatsby-telemetry/src/event-storage.ts +++ b/packages/gatsby-telemetry/src/event-storage.ts @@ -56,7 +56,7 @@ export class EventStorage { const eventString = JSON.stringify(event) if (this.debugEvents || this.verbose) { - console.error(`Captured event:`, JSON.parse(eventString)) + console.log(`Captured event:`, JSON.parse(eventString)) if (this.debugEvents) { // Bail because we don't want to send debug events