Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starter library - github stars confusion #10285

Closed
shannonbux opened this issue Dec 4, 2018 · 10 comments
Closed

Starter library - github stars confusion #10285

shannonbux opened this issue Dec 4, 2018 · 10 comments
Assignees

Comments

@shannonbux
Copy link
Contributor

Description

The yellow stars in the starter library confused some users in interviews. They thought they were rating stars (as in Amazon stars) instead of github stars.

Steps to reproduce

When people arrive at /starters/, many of them glance at the yellow stars and think they are rating stars when they are actually supposed to represent github stars.

Expected result

When people arrive on the /starters/ page, they want to be able to choose a high quality starter. We need to make sure the information about each starters helps people know which one they want to try.

Actual result

When people arrive at /starters/, many of them glance at the yellow stars and think "why do all of these starters only have a one star rating?"

Environment

Browser window

Suggested solution

We could make the stars black so they mimic the github look and feel for stars. We could also mimic the design more fully from GitHub:

screen shot 2018-12-04 at 11 18 36 am

@LekoArts
Copy link
Contributor

LekoArts commented Dec 4, 2018

I'm really surprised that people actually think that. On Amazon you have a scale from 1-5 that immediately can be seen:

image

The Gatsby site doesn't have such a scale, and while there are starters with 1 star there are also others with 688. What scale would that be?! 😆

If changes are necessary, I could quickly incorporate them here: #10258

@amberleyromo
Copy link
Contributor

@LekoArts that would be great. I think the easiest thing to do here would be to set it to the same dark gray as the surrounding text. As Shannon suggested, perhaps that will more resemble GitHub, and not being a "yellow star" will take away the rating impression.

@LekoArts
Copy link
Contributor

LekoArts commented Dec 4, 2018

Dark:

image

Same Color:

image

@amberleyromo
Copy link
Contributor

@LekoArts asking for preferences? personally i like it the same color, rather than darker (second screenshot).

@LekoArts
Copy link
Contributor

LekoArts commented Dec 4, 2018

I wasn't sure what you meant exactly so I did both :whynotboth:
I second the second one (duh)

@shannonbux
Copy link
Contributor Author

shannonbux commented Dec 4, 2018 via email

@LekoArts
Copy link
Contributor

LekoArts commented Dec 4, 2018

Pushed the "light" version up the PR

@amberleyromo
Copy link
Contributor

Closing with #10258.

@LekoArts
Copy link
Contributor

LekoArts commented Dec 5, 2018

#10258 was merged

@LekoArts LekoArts closed this as completed Dec 5, 2018
@shannonbux
Copy link
Contributor Author

shannonbux commented Dec 6, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants