-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starter library - github stars confusion #10285
Comments
I'm really surprised that people actually think that. On Amazon you have a scale from 1-5 that immediately can be seen: The Gatsby site doesn't have such a scale, and while there are starters with 1 star there are also others with 688. What scale would that be?! 😆 If changes are necessary, I could quickly incorporate them here: #10258 |
@LekoArts that would be great. I think the easiest thing to do here would be to set it to the same dark gray as the surrounding text. As Shannon suggested, perhaps that will more resemble GitHub, and not being a "yellow star" will take away the rating impression. |
@LekoArts asking for preferences? personally i like it the same color, rather than darker (second screenshot). |
I wasn't sure what you meant exactly so I did both :whynotboth: |
Yeah, same color looks fine to me!
I think the confusion just comes from the automatic impression people get
from yellow stars, even though once they look at it closer, they realize
the stars are not like Amazon :)
…On Tue, Dec 4, 2018 at 12:13 PM Amberley ***@***.***> wrote:
@LekoArts <https://github.com/LekoArts> asking for preferences?
personally i like it the same color, rather than darker (second screenshot).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10285 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ae9o2iqccz5Xg8XEApZRIlbZc76Ea_tOks5u1td4gaJpZM4ZBVV4>
.
|
Pushed the "light" version up the PR |
Closing with #10258. |
#10258 was merged |
Wohoo! Thanks @LekoArts!
…On Wed, Dec 5, 2018 at 1:40 PM Lennart ***@***.***> wrote:
#10258 <#10258> was merged
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10285 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ae9o2jt3bE3ymooWZCgZBjpk0rjjwVfyks5u2D0vgaJpZM4ZBVV4>
.
|
Description
The yellow stars in the starter library confused some users in interviews. They thought they were rating stars (as in Amazon stars) instead of github stars.
Steps to reproduce
When people arrive at /starters/, many of them glance at the yellow stars and think they are rating stars when they are actually supposed to represent github stars.
Expected result
When people arrive on the /starters/ page, they want to be able to choose a high quality starter. We need to make sure the information about each starters helps people know which one they want to try.
Actual result
When people arrive at /starters/, many of them glance at the yellow stars and think "why do all of these starters only have a one star rating?"
Environment
Browser window
Suggested solution
We could make the stars black so they mimic the github look and feel for stars. We could also mimic the design more fully from GitHub:
The text was updated successfully, but these errors were encountered: