[gatsby-source-shopify] create parent-child link between products and variants

[alexluong]

Summary

Create parent-child link between ShopifyProduct and ShopifyProductVariant

Motivation

When working with Shopify, some time it's quite helpful to go up 1 level from variant to product. One example is to get product thumbnails from checkout.lineItems which contains variantIds.

---

I'd love to hear what you think about this idea?

[pieh]

Generally agree, just would want to clarify that this shouldn't be parent/child in sense of "gatsby nodes", but instead it should be regular link that will allow to traverse from variant to product.

From what I understand gatsby-source-shopify let's you access variants from product:

gatsby/packages/gatsby-source-shopify/src/nodes.js

Lines 102 to 110 in 3197b69

	if (node.variants) {
	const variants = node.variants.edges.map(edge => edge.node)
	node.variants___NODE = variants.map(variant =>
	generateNodeId(PRODUCT_VARIANT, variant.id)
	)
	delete node.variants
	}

We would need similar thing for

gatsby/packages/gatsby-source-shopify/src/nodes.js

Lines 148 to 169 in 3197b69

	export const ProductVariantNode = imageArgs =>
	createNodeFactory(PRODUCT_VARIANT, async node => {
	if (node.metafields) {
	const metafields = node.metafields.edges.map(edge => edge.node)
	node.metafields___NODE = metafields.map(metafield =>
	generateNodeId(PRODUCT_VARIANT_METAFIELD, metafield.id)
	)
	delete node.metafields
	}
	if (node.image)
	node.image.localFile___NODE = await downloadImageAndCreateFileNode(
	{
	id: node.image.id,
	url: node.image.originalSrc && node.image.originalSrc.split(`?`)[0],
	},
	imageArgs
	)
	return node
	})

That would set product___NODE (but we would have to pass product node (full object or id) to that factory from

gatsby/packages/gatsby-source-shopify/src/gatsby-node.js

Lines 89 to 99 in 3197b69

	if (x.variants)
	await forEach(x.variants.edges, async edge => {
	const v = edge.node
	if (v.metafields)
	await forEach(v.metafields.edges, async edge =>
	createNode(
	await ProductVariantMetafieldNode(imageArgs)(edge.node)
	)
	)
	return createNode(await ProductVariantNode(imageArgs)(edge.node))
	})

[alexluong]

@pieh Thanks for promptly addressing the issue. I'd be happy to work on this.

[github-actions]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

[github-actions]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

[jzabala]

Hi @alexluong, still working on this one?

[alexluong]

Hey @jzabala, no I'm not working on this one. Turn out there are other ways to solve my problem.

I still think this is a great addition though. Feel free to take it on!

[jzabala]

Hey @jzabala, no I'm not working on this one. Turn out there are other ways to solve my problem.

I still think this is a great addition though. Feel free to take it on!

Awesome @alexluong. Thanks for letting me know.

[LekoArts]

Hi! We've released a new major verison (v5) which fundamentally works different. Please try the upgrade and if you still hit this please open a new issue with a reproduction. Thanks!