-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need warning in docs about bumping master branch during deployment to gh pages #24479
Comments
Hi, thanks for the issue! What issue did you face? The issue you linked is working as intended and the docs explain this usecase. |
@LekoArts added description of the problem |
Reading your updated comment I feel like you should follow these instructions, right? Because with this script you'll always deploy to another branch than |
No, correct link is https://www.gatsbyjs.org/docs/how-gatsby-works-with-github-pages/#deploying-to-a-github-pages-subdomain-at-githubio GH pages forces to deploy to master branch for user\organization pages. |
Ah, I see! Documenting those two options (#13120 (comment)) sounds reasonable. Would you be up for opening a PR adding this? :) |
Sure! |
* Close #24479 * chore: format * Update docs/docs/how-gatsby-works-with-github-pages.md Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com> * Update docs/docs/how-gatsby-works-with-github-pages.md Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com> * Update docs/docs/how-gatsby-works-with-github-pages.md Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com> * Update docs/docs/how-gatsby-works-with-github-pages.md Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com> * Update docs/docs/how-gatsby-works-with-github-pages.md Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com> Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
* Close #24479 * chore: format * Update docs/docs/how-gatsby-works-with-github-pages.md Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com> * Update docs/docs/how-gatsby-works-with-github-pages.md Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com> * Update docs/docs/how-gatsby-works-with-github-pages.md Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com> * Update docs/docs/how-gatsby-works-with-github-pages.md Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com> * Update docs/docs/how-gatsby-works-with-github-pages.md Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com> Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
* Close gatsbyjs#24479 * chore: format * Update docs/docs/how-gatsby-works-with-github-pages.md Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com> * Update docs/docs/how-gatsby-works-with-github-pages.md Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com> * Update docs/docs/how-gatsby-works-with-github-pages.md Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com> * Update docs/docs/how-gatsby-works-with-github-pages.md Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com> * Update docs/docs/how-gatsby-works-with-github-pages.md Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com> Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
Recently I faced same issue as described here
Maybe we need some sort of warning or tip in docs about that issue?
Short description of the problem:
We are developing something on the
master
btanch as usual. And want to deploy it on Github Pages. We see in the documentation how to do that in Gatsby world but don't pay attention to that we are bumping our master branch. So I would suggest adding a tip to checkoutmaster
branch tosource
branch before runningnpm run deploy
.The text was updated successfully, but these errors were encountered: