Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV_SSR broke , render.page output dont have all page chunk references #31810

Closed
simonjoom opened this issue Jun 7, 2021 · 3 comments
Closed
Labels
status: needs reproduction This issue needs a simplified reproduction of the bug for further troubleshooting. topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)

Comments

@simonjoom
Copy link

simonjoom commented Jun 7, 2021

For me this timeout 1500 is not enough and did break the result of store.dispatch(createServerVisitedPage) which not compiled in the result in render.page.js
( i have got just dev_404 component---cache-dev-404-page-js and i haven t got component---src-templates-tppage-jsx of the current page inside)

This issue is related that debouncedWriteAll use a timeout of 500 too.
As a result i have got a break ssr at the end. (client work but ssr output not correct

I guess need to allow user to increase the timeout or find a solution without hacky timeout...

I have got a large project , 1500s is not enough to wait after compilation ..
A solution should to give the choice to user to wait again or to increase timeout

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 7, 2021
@vladar vladar added topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 7, 2021
@vladar
Copy link
Contributor

vladar commented Jun 7, 2021

Hi @simonjoom

Sorry to hear you're running into an issue. To help us best begin debugging the underlying cause, it is incredibly helpful if you're able to create a minimal reproduction. This is a simplified example of the issue that makes it clear and obvious what the issue is and how we can begin to debug it.

If you're up for it, we'd very much appreciate if you could provide a minimal reproduction and we'll be able to take another look.

Thanks for using Gatsby! 💜

@vladar vladar added the status: needs reproduction This issue needs a simplified reproduction of the bug for further troubleshooting. label Jun 7, 2021
@simonjoom
Copy link
Author

simonjoom commented Jun 8, 2021

sorry mate, my project is big just need to test with a project with code enough big to create a slow compilation for webpack.

1500sec is not enoughfor me to continue the execution without waiting the final output
webpack recreate the render-page.js which is used by ensurePathComponentInSSRBundle to check existance of chunk and if the process is not waited properly then render-page is not updated for ensurePathComponentInSSRBundle to see the chunks.

My explanation seems for me enough to rethink about this part of code, testing it is not necessary when we can see obvious issue.

@LekoArts
Copy link
Contributor

LekoArts commented Jun 8, 2021

Hi, thanks for the issue!

I see that your issue is about a specific experiment/flag we currently have. We collect any feedback (bug reports, feature requests, questions, etc.) inside a respective discussion in the Umbrella Discussions category.

Please direct your feedback here: #28138

Thanks!

@LekoArts LekoArts closed this as completed Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs reproduction This issue needs a simplified reproduction of the bug for further troubleshooting. topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Projects
None yet
Development

No branches or pull requests

3 participants