Expose crop focus parameter and make consistent with base64 #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit a688782 |
|
Deploy preview failed. Built with commit e7adfa6 https://app.netlify.com/sites/using-postcss-sass/deploys/592b0a71424ef224a682ca62 |
|
Deploy preview ready! Built with commit a688782 |
|
Deploy preview ready! Built with commit a688782 |
|
👍 to exposing the focus options. But let's keep the default to attention as it's the best general option lovell/sharp#295 (comment) |
|
OK! 👍 (force pushed in one commit) |
|
Glad you're cleaning things up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there was a difference in image cropping between base64 true/false, and found that one of them was using
sharp.strategy.attention. I decided to set the default back to the sharp default (center) and expose all the different options in the API.I also found that the force format fix from earlier today still had to be applied to the base64 part.