[1.0] Ignore SVGs in gatsby-remark-responsive-image (#1145) #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and instead just copy them alongside GIFs in gatsby-remark-copy-linked-files.
fk
changed the title
|
Deploy preview ready! Built with commit 2606c3a |
|
Deploy preview failed. Built with commit 2606c3a https://app.netlify.com/sites/gatsbyjs/deploys/593f3ba26f4c50516af8a13f |
|
Deploy preview ready! Built with commit 2606c3a |
|
Ready to merge, fixes #1145 and GIFs getting copied as |
| visit(markdownAST, `image`, image => { | ||
| if (image.url.slice(-3) === `gif`) { | ||
| const fileType = image.url.slice(-3) |
There was a problem hiding this comment.
This is unnecessarily fragile code now that I think about it... we can just get the actual extension off linkNode as we do above.
There was a problem hiding this comment.
Got to sleep, but pushed something very redundant ;)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and instead just copy them alongside GIFs in gatsby-remark-copy-linked-files.
WIP, currently all SVGs get copied to
publicasundefined.svg:D