Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update Adding React Components #21284

Merged
merged 6 commits into from
Feb 11, 2020

Conversation

AishaBlake
Copy link

Description

Having gone through a workflow evaluation for working with style libraries and components, we identified some useful updates for the page on Adding React Components. These are listed in issue #21278.

Related Issues

Addresses #21278

@AishaBlake AishaBlake added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Feb 7, 2020
@AishaBlake AishaBlake requested a review from a team as a code owner February 7, 2020 23:33
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Made a couple suggestions but think it'll be ready to go shortly.

docs/docs/adding-react-components.md Show resolved Hide resolved
docs/docs/adding-react-components.md Outdated Show resolved Hide resolved
docs/docs/adding-react-components.md Show resolved Hide resolved
Aisha Blake and others added 2 commits February 7, 2020 16:00
Co-Authored-By: LB <barth.laurie@gmail.com>
@AishaBlake
Copy link
Author

@laurieontech I think this is ready for another look!

Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick additional comment! But looks great.

docs/docs/adding-react-components.md Outdated Show resolved Hide resolved
Aisha Blake and others added 3 commits February 10, 2020 08:02
@laurieontech
Copy link
Contributor

Looks great. Thanks Aisha!

@laurieontech laurieontech merged commit 5d09434 into master Feb 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the adding-react-components-update branch February 11, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants