Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): Test on Node 14 #23354

Merged
merged 4 commits into from
Jun 26, 2020
Merged

chore(test): Test on Node 14 #23354

merged 4 commits into from
Jun 26, 2020

Conversation

MichaelDeBoey
Copy link
Contributor

Description

Add tests for Node 14

@MichaelDeBoey MichaelDeBoey requested a review from a team as a code owner April 21, 2020 19:30
@wardpeet
Copy link
Contributor

I rather not test on 14 yet, we already testing 10,12,13, this will add extra slowdown to all our PRs. Perhaps we should start running it nightly.

I'll ask others, what they think.

@wardpeet
Copy link
Contributor

wardpeet commented May 6, 2020

Can you make these test run weekly for now?

@LekoArts
Copy link
Contributor

cc @MichaelDeBoey

@LekoArts LekoArts added status: awaiting author response Additional information has been requested from the author type: chore labels Jun 22, 2020
@LekoArts LekoArts removed the status: awaiting author response Additional information has been requested from the author label Jun 22, 2020
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@LekoArts LekoArts changed the title test: Test on Node 14 chore(test): Test on Node 14 Jun 26, 2020
@LekoArts LekoArts merged commit 1cf0c27 into gatsbyjs:master Jun 26, 2020
@MichaelDeBoey MichaelDeBoey deleted the node-14 branch June 26, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants