From f40323b20b8206f418a7d7c8fbff2f8a845083ac Mon Sep 17 00:00:00 2001
From: John Otander <johnotander@gmail.com>
Date: Tue, 5 May 2020 03:40:24 -0600
Subject: [PATCH] fix(gatsby-recipes): Fix gatsby config all function

---
 .../gatsby/__snapshots__/plugin.test.js.snap  | 108 ++++++++++++++++++
 .../src/providers/gatsby/plugin.js            |   8 +-
 .../src/providers/gatsby/plugin.test.js       |   6 +
 3 files changed, 118 insertions(+), 4 deletions(-)

diff --git a/packages/gatsby-recipes/src/providers/gatsby/__snapshots__/plugin.test.js.snap b/packages/gatsby-recipes/src/providers/gatsby/__snapshots__/plugin.test.js.snap
index d233209340074..ece76f64ae6bc 100644
--- a/packages/gatsby-recipes/src/providers/gatsby/__snapshots__/plugin.test.js.snap
+++ b/packages/gatsby-recipes/src/providers/gatsby/__snapshots__/plugin.test.js.snap
@@ -1,5 +1,113 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`gatsby-plugin resource all returns plugins as array 1`] = `
+Array [
+  Object {
+    "id": "gatsby-source-filesystem",
+    "name": "gatsby-source-filesystem",
+    "options": Object {
+      "name": "pages",
+      "path": "\${__dirname}/src/pages",
+    },
+    "shadowableFiles": Array [],
+    "shadowedFiles": Array [],
+  },
+  Object {
+    "id": "gatsby-transformer-sharp",
+    "name": "gatsby-transformer-sharp",
+    "options": undefined,
+    "shadowableFiles": Array [],
+    "shadowedFiles": Array [],
+  },
+  Object {
+    "id": "gatsby-plugin-emotion",
+    "name": "gatsby-plugin-emotion",
+    "options": undefined,
+    "shadowableFiles": Array [],
+    "shadowedFiles": Array [],
+  },
+  Object {
+    "id": "gatsby-plugin-typography",
+    "name": "gatsby-plugin-typography",
+    "options": Object {
+      "pathToConfigModule": "src/utils/typography",
+    },
+    "shadowableFiles": Array [],
+    "shadowedFiles": Array [],
+  },
+  Object {
+    "id": "gatsby-transformer-remark",
+    "name": "gatsby-transformer-remark",
+    "options": Object {
+      "plugins": Array [
+        Object {
+          "options": Object {
+            "maxWidth": 590,
+          },
+          "resolve": "gatsby-remark-images",
+        },
+        Object {
+          "options": Object {
+            "wrapperStyle": "margin-bottom: 1.0725rem",
+          },
+          "resolve": "gatsby-remark-responsive-iframe",
+        },
+        "gatsby-remark-prismjs",
+        "gatsby-remark-copy-linked-files",
+        "gatsby-remark-smartypants",
+      ],
+    },
+    "shadowableFiles": Array [],
+    "shadowedFiles": Array [],
+  },
+  Object {
+    "id": "gatsby-plugin-sharp",
+    "name": "gatsby-plugin-sharp",
+    "options": undefined,
+    "shadowableFiles": Array [],
+    "shadowedFiles": Array [],
+  },
+  Object {
+    "id": "gatsby-plugin-google-analytics",
+    "name": "gatsby-plugin-google-analytics",
+    "options": Object {
+      "trackingId": "UA-774017-3",
+    },
+    "shadowableFiles": Array [],
+    "shadowedFiles": Array [],
+  },
+  Object {
+    "id": "gatsby-plugin-manifest",
+    "name": "gatsby-plugin-manifest",
+    "options": Object {
+      "background_color": null,
+      "display": "minimal-ui",
+      "icon": "static/logo.png",
+      "name": "Bricolage",
+      "short_name": "Bricolage",
+      "start_url": "/",
+      "theme_color": null,
+    },
+    "shadowableFiles": Array [],
+    "shadowedFiles": Array [],
+  },
+  Object {
+    "id": "gatsby-plugin-offline",
+    "name": "gatsby-plugin-offline",
+    "options": undefined,
+    "shadowableFiles": Array [],
+    "shadowedFiles": Array [],
+  },
+  Object {
+    "id": "gatsby-plugin-react-helmet",
+    "name": "gatsby-plugin-react-helmet",
+    "options": undefined,
+    "shadowableFiles": Array [],
+    "shadowedFiles": Array [],
+  },
+]
+`;
+
 exports[`gatsby-plugin resource creates default gatsby-config.js if there isn't one already 1`] = `
 Object {
   "_message": "Installed gatsby-plugin-foo in gatsby-config.js",
diff --git a/packages/gatsby-recipes/src/providers/gatsby/plugin.js b/packages/gatsby-recipes/src/providers/gatsby/plugin.js
index 98170b94983da..9aa32d4af7f46 100644
--- a/packages/gatsby-recipes/src/providers/gatsby/plugin.js
+++ b/packages/gatsby-recipes/src/providers/gatsby/plugin.js
@@ -314,15 +314,15 @@ module.exports.all = async ({ root }) => {
   const plugins = getPluginsFromConfig(configSrc)
 
   // TODO: Consider mapping to read function
-  return plugins.map(name => {
+  return plugins.map(plugin => {
     const { shadowedFiles, shadowableFiles } = listShadowableFilesForTheme(
       root,
-      name
+      plugin.name
     )
 
     return {
-      id: name,
-      name,
+      id: plugin.name,
+      ...plugin,
       shadowedFiles,
       shadowableFiles,
     }
diff --git a/packages/gatsby-recipes/src/providers/gatsby/plugin.test.js b/packages/gatsby-recipes/src/providers/gatsby/plugin.test.js
index dd238ec6b7b03..c2cebe9e6afcd 100644
--- a/packages/gatsby-recipes/src/providers/gatsby/plugin.test.js
+++ b/packages/gatsby-recipes/src/providers/gatsby/plugin.test.js
@@ -62,6 +62,12 @@ describe(`gatsby-plugin resource`, () => {
     })
   })
 
+  test(`all returns plugins as array`, async () => {
+    const result = await plugin.all({ root: STARTER_BLOG_FIXTURE })
+
+    expect(result).toMatchSnapshot()
+  })
+
   test(`does not add the same plugin twice by default`, async () => {
     const configSrc = await fs.readFile(configPath, `utf8`)
     let newConfigSrc = addPluginToConfig(configSrc, {