Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): mention async/await syntax in Gatsby Node APIs docs #24752

Merged
merged 1 commit into from
Jun 10, 2020
Merged

chore(docs): mention async/await syntax in Gatsby Node APIs docs #24752

merged 1 commit into from
Jun 10, 2020

Conversation

damianstasik
Copy link
Contributor

Description

I extended the Async plugins section in Gatsby Node APIs docs to include mention about the async/await syntax.

@damianstasik damianstasik requested a review from a team as a code owner June 3, 2020 13:31
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 3, 2020
@vladar vladar added status: needs dx review and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 3, 2020
marcysutton
marcysutton approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we'd prefer an issue first describing the problem at hand before a PR. But this looks ok to me, so I'll approve it. Thanks so much!

@marcysutton marcysutton merged commit 130d5b7 into master Jun 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the visualfanatic-patch-1 branch June 10, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcysutton marcysutton marcysutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damianstasik @marcysutton @vladar @visualfanatic