chore(www): convert BoxWithBorder to theme-ui #25144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: website
and removed
status: triage needed
tesseralis
suggested changes
Jun 25, 2020
| ":after": withBorder && { | ||
| content: `" "`, | ||
| border: `1px solid ${t.colors.blackFade[10]}`, | ||
| borderRadius: t => t.radii[1], |
There was a problem hiding this comment.
Since borderRadius is theme-aware I think you can just replace this with just:
Suggested change
| borderRadius: t => t.radii[1], | |
| borderRadius: 1, |
| position: `relative`, | ||
| ":after": withBorder && { | ||
| content: `" "`, | ||
| border: `1px solid ${t.colors.blackFade[10]}`, |
There was a problem hiding this comment.
Should this be:
Suggested change
| border: `1px solid ${t.colors.blackFade[10]}`, | |
| border: t => `1px solid ${t.colors.blackFade[10]}`, |
Alternately we could do:
Suggested change
| border: `1px solid ${t.colors.blackFade[10]}`, | |
| borderWidth: `1px`, | |
| borderStyle: `solid`, | |
| borderColor: `blackFade.10`, |
There was a problem hiding this comment.
I totally agree with you
abhishekjakhar
added
the
status: awaiting reviewer response
tesseralis
approved these changes
Jun 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<BoxWithBorder/>component to theme-uiScreenshot(s)
The logo container is wrapper in BoxWithBorder component
The items inside Guidance are all wrapped inside BoxWithBorder component
How to test
Local URL: http://localhost:8000/guidelines/logo/
Production URL: https://www.gatsbyjs.org/guidelines/logo/