Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): Add explanation of Site.siteMetadata field #25208

Merged

Conversation

TylerBarnes
Copy link
Contributor

This PR updates the docs at this page https://www.gatsbyjs.org/docs/internal-data-bridge/#site to provide more info about the Site.siteMetadata field.

The todo on that page mentions #14228 but I'm not totally sure that that's the right issue since that's about Schema Customization and this is about the internal data bridge.

@TylerBarnes TylerBarnes requested a review from a team as a code owner June 22, 2020 16:26
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 22, 2020
@TylerBarnes TylerBarnes added the status: needs docs review Pull request related to documentation waiting for review label Jun 22, 2020
@TylerBarnes TylerBarnes self-assigned this Jun 22, 2020
@TylerBarnes TylerBarnes removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 22, 2020
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, Tyler!

@marcysutton marcysutton merged commit e59b4a9 into master Jun 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the feat/update-internal-data-bridge-sitemetadata-docs branch June 25, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs docs review Pull request related to documentation waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants