Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect vercel again after rebranding in gatsby-telemetry #25883

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Detect vercel again after rebranding in gatsby-telemetry #25883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bc19c1
Detect vercel again after rebranding as per https://vercel.com/docs/v…
jamo Jul 20, 2020
022e189
Add another Vercel NOW matcher
jamo Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/gatsby-core-utils/src/ci.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ const CI_DEFINITIONS = [
envFromCIandCIName,
getEnvDetect({ key: `NOW_BUILDER_ANNOTATE`, name: `ZEIT Now` }),
getEnvDetect({ key: `NOW_REGION`, name: `ZEIT Now v1` }),
getEnvDetect({ key: `VERCEL_URL`, name: `Vercel Now` }),
getEnvDetect({ key: `NOW_BUILDER`, name: `Vercel Now` }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when i look at this doc: the NOW_BUILDER is also renamed to VERCEL_BUILDER:

https://www.notion.so/Change-Timeline-fab7622780694753a92c0a396cea7eb6

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc #24019

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they still expose NOW_BUILDER 🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tho why not add both should they one day fix it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#25926

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing projects will get both NOW_ and VERCEL_ env. New projects will only get VERCEL_ env.

there is no info about an expire

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they still expose NOW_BUILDER 🙈

only on existing apps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd create a new app fwiw

Copy link
Contributor

@muescha muescha Jul 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this i not checked...

herokuDetect,
getEnvFromCIInfo,
envFromCIWithNoName,
Expand Down