Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(gatsby-plugin-mdx): drop another babel step during sourcing #26003

Closed
wants to merge 1 commit into from

Conversation

laurieontech
Copy link
Contributor

This is the original PR plus some changes for backwards compatibility. There is a still a race condition in this code we need to solve for.

Fixes #25975

This Babel step was used to get exports and remark header but we can use the mdast for this purpose, just like for imports. See PR for perf numbers but they are big.
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 24, 2020
@laurieontech laurieontech added topic: MDX and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 24, 2020
@gatsby-cloud-staging
Copy link

gatsby-cloud-staging bot commented Jul 24, 2020

Gatsby Cloud Build Report

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

Performance

Lighthouse report

Metric Score
Performance 💚 95
Accessibility 🔶 87
Best Practices 💚 93
SEO 🔶 73

🔗 View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent MDX PR changed function signature of createMDXNode
2 participants