Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): governance model -> fix 404 on internal links #26370

Merged
merged 1 commit into from
Sep 4, 2020
Merged

fix(docs): governance model -> fix 404 on internal links #26370

merged 1 commit into from
Sep 4, 2020

Conversation

muescha
Copy link
Contributor

@muescha muescha commented Aug 11, 2020

Description

changes:

  • fix links /docs/contributing -> /contributing

Related Issues

@muescha muescha requested a review from a team as a code owner August 11, 2020 17:02
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 11, 2020
@muescha muescha mentioned this pull request Aug 11, 2020
Merged
bitmaks
bitmaks reviewed Aug 12, 2020
View reviewed changes
Copy link
Contributor

@bitmaks bitmaks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fix all errors as some internal links are located at /docs/... this breaks some currently functional links and fixes some. I think this needs some more review. Seems to break "Contributing to Gatsby.js". I believe the actual error is caused by the lack of .md at the end of the links.

@bitmaks bitmaks added type: documentation An issue or pull request for improving or updating Gatsby's documentation status: awaiting author response Additional information has been requested from the author and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 12, 2020
@muescha
Copy link
Contributor Author

muescha commented Aug 12, 2020 •
edited
Loading

@aaaakshat please run localy:

gatsby develop

and go to:

http://localhost:8000/contributing/gatsby-governance-model

Note: the root for gatsbyjs.org is https://github.com/gatsbyjs/gatsby/blob/master/docs/

@muescha muescha requested a review from bitmaks August 12, 2020 15:28
@bitmaks bitmaks added status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response Additional information has been requested from the author labels Aug 12, 2020
LekoArts
LekoArts approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@LekoArts LekoArts merged commit 8b1f670 into gatsbyjs:master Sep 4, 2020
@muescha muescha deleted the muescha/fix/doc-governance-404 branch September 19, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitmaks bitmaks bitmaks approved these changes

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muescha @LekoArts @bitmaks