Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby): Add eslint rules to warn against bad patterns in pageTemplates (for Fast Refresh) #28689

Merged
merged 25 commits into from
Jan 15, 2021
Merged

feat(gatsby): Add eslint rules to warn against bad patterns in pageTemplates (for Fast Refresh) #28689

merged 25 commits into from
Jan 15, 2021

Commits on Dec 18, 2020

  1. tmp: add preliminary babel plugin for page templates to warn when tho… 

    …se won't work with fast refresh
    @pieh
    pieh committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    94449a6 View commit details
    Browse the repository at this point in the history

  2. slight reorder of warning message to be bit more readable (filename i… 

    …n middle, not in the end)
    @pieh
    pieh committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    ff80b61 View commit details
    Browse the repository at this point in the history

  3. fix lint?

    @pieh
    pieh committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    82964c7 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Merge remote-tracking branch 'upstream/master' into fast-refresh/ensu… 

    …re-named-page-templates
    gatsbybot committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    f98c030 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. update messages

    @LekoArts
    LekoArts committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    b12b7d6 View commit details
    Browse the repository at this point in the history

  2. Improve warning messages and also add warning to other default export… 

    …ed lowercase components
    @LekoArts
    LekoArts committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    2ea5561 View commit details
    Browse the repository at this point in the history

  3. add onWarning

    @LekoArts
    LekoArts committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    69db5a3 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into fast-refresh/ensu… 

    …re-named-page-templates
    gatsbybot committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    342866f View commit details
    Browse the repository at this point in the history

  5. revert previous changes

    @LekoArts
    LekoArts committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    40a4ee1 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. revert previous changes

    @LekoArts
    LekoArts committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    b120c37 View commit details
    Browse the repository at this point in the history

  2. use two local rules

    @LekoArts
    LekoArts committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    aeb8040 View commit details
    Browse the repository at this point in the history

  3. return correct empty object

    @LekoArts
    LekoArts committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    a6b7c5e View commit details
    Browse the repository at this point in the history

  4. exlude template queries

    @LekoArts
    LekoArts committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    72c0e5a View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. add e2e tests

    @LekoArts
    LekoArts committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    fd895b2 View commit details
    Browse the repository at this point in the history

  2. add first unit test

    @LekoArts
    LekoArts committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    a5b8305 View commit details
    Browse the repository at this point in the history

  3. unit test for page exports

    @LekoArts
    LekoArts committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    a356876 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. review comments

    @LekoArts
    LekoArts committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    4ba90f7 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2021

  1. handle multiple declarations

    @LekoArts
    LekoArts committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    908077c View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. feat(gatsby): add required eslint rules even if user has custom eslin… 

    …t config (#28911)

* feat(gatsby): add required eslint rules even if user has custom eslint config

* handle case when extends is single string, add some tests

* some extra existance checking

* more exact checks for existance of eslint-loader rule

* let's see if slash fixes win32 + env var for rules

* another try

* don't use slash after all

Co-authored-by: LekoArts <lekoarts@gmail.com>
    @pieh @LekoArts
    pieh and LekoArts authored Jan 13, 2021
    Configuration menu
    Copy the full SHA
    24468c1 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Peter van der Zee <209817+pvdz@users.noreply.github.com>
    @LekoArts @pvdz
    LekoArts and pvdz authored Jan 14, 2021
    Configuration menu
    Copy the full SHA
    8cf7475 View commit details
    Browse the repository at this point in the history

  2. fix consistent return

    @LekoArts
    LekoArts committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    df460b2 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. add describe block so that IDEs can run them :D

    @LekoArts
    LekoArts committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    2a814b9 View commit details
    Browse the repository at this point in the history

  2. handle more complicated cases

    @LekoArts
    LekoArts committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    765986f View commit details
    Browse the repository at this point in the history

  3. add one more case

    @LekoArts
    LekoArts committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    0fd9deb View commit details
    Browse the repository at this point in the history

  4. handle commonjs syntax

    @LekoArts
    LekoArts committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    2252bf7 View commit details
    Browse the repository at this point in the history