Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-netlify): Add an allow list for redirect options #30155

Merged
merged 3 commits into from
Mar 11, 2021
Merged

fix(gatsby-plugin-netlify): Add an allow list for redirect options #30155

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4d684a
Add allow list for Netlify redirect options
sidharthachatterjee Mar 10, 2021
5d6adc8
Remove console log
sidharthachatterjee Mar 10, 2021
6f4bb18
Add Language and Country
sidharthachatterjee Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions packages/gatsby-plugin-netlify/src/create-redirects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,16 @@ export default async function writeRedirectsFile(

const FILE_PATH = publicFolder(`_redirects`)

// Map redirect data to the format Netlify expects
// https://www.netlify.com/docs/redirects/
const NETLIFY_REDIRECT_KEYWORDS_ALLOWLIST = [
`query`,
`conditions`,
`headers`,
`signed`,
`edge_handler`,
]
sidharthachatterjee marked this conversation as resolved.
Show resolved Hide resolved

// Map redirect data to the format Netlify expects
redirects = redirects.map(redirect => {
const {
fromPath,
Expand All @@ -37,13 +45,17 @@ export default async function writeRedirectsFile(
for (const key in rest) {
const value = rest[key]

console.log(NETLIFY_REDIRECT_KEYWORDS_ALLOWLIST)
sidharthachatterjee marked this conversation as resolved.
Show resolved Hide resolved

if (typeof value === `string` && value.includes(` `)) {
console.warn(
`Invalid redirect value "${value}" specified for key "${key}". ` +
`Values should not contain spaces.`
)
} else {
pieces.push(`${key}=${value}`)
if (NETLIFY_REDIRECT_KEYWORDS_ALLOWLIST.includes(key)) {
pieces.push(`${key}=${value}`)
}
}
}

Expand Down