-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-source-wordpress): use image cdn for non-resizable images in html (svgs/gifs mainly) #35529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Apr 29, 2022
TylerBarnes
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Apr 29, 2022
TylerBarnes
changed the title
feat(gatsby-source-wordpress): use image cdn for files in html
feat(gatsby-source-wordpress): use image cdn for non-resizable images in html
Apr 29, 2022
TylerBarnes
commented
Apr 30, 2022
@@ -414,26 +414,6 @@ const copyFileToStaticAndReturnUrlPath = async (fileNode, helpers) => { | |||
return relativeUrl | |||
} | |||
|
|||
const filterMatches = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function isn't being used anywhere 🤔 not sure why but it was dead code so I deleted it
TylerBarnes
changed the title
feat(gatsby-source-wordpress): use image cdn for non-resizable images in html
feat(gatsby-source-wordpress): use image cdn for non-resizable images in html (svgs/gifs mainly)
Apr 30, 2022
Hmm, tests are failing 🤔 I'll fix |
LekoArts
added
topic: source-wordpress
Related to Gatsby's integration with WordPress
topic: source-plugins
Relates to the Gatsby source plugins (e.g. -filesystem)
labels
May 3, 2022
wardpeet
previously approved these changes
May 4, 2022
This was referenced Nov 29, 2022
This was referenced Nov 29, 2022
This was referenced Feb 28, 2023
This was referenced Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: source-plugins
Relates to the Gatsby source plugins (e.g. -filesystem)
topic: source-wordpress
Related to Gatsby's integration with WordPress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35213