Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-source-wordpress): use image cdn for non-resizable images in html (svgs/gifs mainly) #35529

Merged
merged 11 commits into from
May 4, 2022

Conversation

TylerBarnes
Copy link
Contributor

@TylerBarnes TylerBarnes commented Apr 29, 2022

Fixes #35213

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 29, 2022
@TylerBarnes TylerBarnes removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 29, 2022
@TylerBarnes TylerBarnes changed the title feat(gatsby-source-wordpress): use image cdn for files in html feat(gatsby-source-wordpress): use image cdn for non-resizable images in html Apr 29, 2022
@@ -414,26 +414,6 @@ const copyFileToStaticAndReturnUrlPath = async (fileNode, helpers) => {
return relativeUrl
}

const filterMatches =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function isn't being used anywhere 🤔 not sure why but it was dead code so I deleted it

@TylerBarnes TylerBarnes changed the title feat(gatsby-source-wordpress): use image cdn for non-resizable images in html feat(gatsby-source-wordpress): use image cdn for non-resizable images in html (svgs/gifs mainly) Apr 30, 2022
@TylerBarnes TylerBarnes marked this pull request as ready for review April 30, 2022 01:52
@TylerBarnes
Copy link
Contributor Author

Hmm, tests are failing 🤔 I'll fix

@LekoArts LekoArts added topic: source-wordpress Related to Gatsby's integration with WordPress topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) labels May 3, 2022
wardpeet
wardpeet previously approved these changes May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) topic: source-wordpress Related to Gatsby's integration with WordPress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gatsy 4.10.1 - Gatsby-soure-wp 6.10.0 inline svg's are not given static url yet are rendered with source urls
3 participants