[1.0] Relay Compiler #912
[1.0] Relay Compiler #912
Conversation
|
Deploy preview ready! Built with commit 2de79bd |
|
Deploy preview ready! Built with commit 2de79bd |
|
Deploy preview ready! Built with commit 2de79bd |
KyleAMathews
force-pushed
the
relay-round-2
branch
from
0f0222b
to
7d18699
Compare
scripts/publish-site.sh
Outdated
| echo "=== find graphql packages" | ||
|
|
||
| find node_modules -name graphql | ||
| echo "=== END find graphql packages" |
There was a problem hiding this comment.
i am hoping this is better after the next npm publish since everything has been moved to peer deps :/
There was a problem hiding this comment.
Did that already... :-\
Can't reproduce locally — it's giving me a weird graphql error where it says the "schema" isn't the correct type.
Breaking out Docker...
There was a problem hiding this comment.
What use do you see to having graphql set as a peerDependency? I'm thinking about just removing it because plugins have to use the same version of GraphQL as Gatsby's core package.
There was a problem hiding this comment.
it should ensure a single instance of it given a fresh install but you know...npm
Maybe the best approach is actually to expose graphql to plugins like babel does for babel.types. like pass in the `graphql' object
There was a problem hiding this comment.
ooo that's an interesting idea.
… latest code to catch errors early
|
Woot! And it's in! |
|
@jquense hrrmm... probably should have squashed and merged this instead of squashing as now it says I wrote all of this code :-( |
|
actually, I'll rewrite the commit to make you the author |
|
Hehe no worries glad it's in! |
* Relay integration * what is the deal with eslint * gatsbygram update * Hacker News example * Drupal example * bonus dependency * Missed adding this * Actually format example code * update dependencies * Get types for nested arguments + handle argument lists * Add missing babel-runtime dependency * Try removing hoisting to see if that fixes site builds * debugging * Updates from @jquense's changes * Set websites to use 'canary' versions of websites so always download latest * Add required yaml-loader * Remove yarn.locks from example sites as we always want to install the latest code to catch errors early * Update www for the new relay compiler * Lengthen debounce so stuff can really finish * Make paths to bin relative * Restore lerna hoisting * Add error and quit if a query name is missing * Dunno if this helps but... * Fix version string * debugging... * More info * Follow links * Add netlify.toml to set yarn version * Turned out not what we want * Get around permission error on Netlify * Don't overwrite the Gatsby bin directory or it'll stop working * Remove this workaround * Remove debuggin
|
no no, whenever people run 'git blame' I want them to come find you not me! |
|
anyways, fixed it already bb772f8 |
This is @jquense's PR #876 with a few fixes I found while trying out our new swanky Relay Compiler integration on my blog.