Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grammar and punctuation #9498

Merged
merged 4 commits into from
Nov 6, 2018
Merged

Fix grammar and punctuation #9498

merged 4 commits into from
Nov 6, 2018

Conversation

imronras
Copy link
Contributor

  • 'Building' to 'The building'
  • 'in the past' to 'in the past,'

@imronras
Fixing grammar
174efc0 
- 'Building' to 'The building'
- 'in the past' to 'in the past,'
@imronras
Merge pull request #1 from imronra/imronra-tutorial-1
c373d8c 
Fixing grammar
@imronras imronras requested a review from a team October 28, 2018 15:14
@imronras imronras changed the title Fixing grammar Fix grammar and punctuation Oct 28, 2018
yeskunall
yeskunall reviewed Oct 29, 2018
View reviewed changes
Copy link
Contributor

@yeskunall yeskunall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 💖

docs/tutorial/part-one/index.md Outdated Show resolved Hide resolved
shannonbux
shannonbux previously requested changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@shannonbux shannonbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve this once you take @yeskunall's suggestion!

Thanks @imronra!

docs/tutorial/part-one/index.md Outdated Show resolved Hide resolved
@DSchau DSchau added the status: awaiting author response Additional information has been requested from the author label Oct 30, 2018
@yeskunall @imronras
Update docs/tutorial/part-one/index.md
d9f914f 
Co-Authored-By: imronra <42175898+imronra@users.noreply.github.com>
@imronras
Copy link
Contributor Author

imronras commented Nov 5, 2018

The suggestion has been applied

DSchau
DSchau approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure; seems reasonable. Thanks!

@DSchau DSchau dismissed shannonbux’s stale review November 6, 2018 14:28

(Made necessary tweaks!)

@DSchau DSchau merged commit 8a12253 into gatsbyjs:master Nov 6, 2018
@gatsbot
Copy link

gatsbot bot commented Nov 6, 2018

Holy buckets, @imronra — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

lipis added a commit to lipis/gatsby that referenced this pull request Nov 6, 2018
@lipis
Merge branch 'master' of github.com:gatsbyjs/gatsby into hooks
20a6521 
* 'master' of github.com:gatsbyjs/gatsby: (63 commits)
  Update how-to-contribute.md to mention the style guide when writing blogs/tutorials (gatsbyjs#9742)
  Added  Tylermcginnis website (gatsbyjs#9619)
  Fix grammar and punctuation (gatsbyjs#9498)
  Fix typo of plugin authoring (gatsbyjs#9737)
  Authentication tutorial - small fixes (gatsbyjs#9738)
  chore: move run-sift (gatsbyjs#9549)
  docs: fix minor typo (gatsbyjs#9730)
  chore(release): Publish
  fix(gatsby-plugin-page-creator): ensure that __tests__ directory is actually ignored (gatsbyjs#9720)
  fix: revert admin redirect (gatsbyjs#9728)
  fix: adjust page order to make nested matchPaths work (gatsbyjs#9719)
  feat(gatsby-plugin-sharp): cache base64 if possible (gatsbyjs#9059)
  chore(release): Publish
  fix(gatsby-plugin-offline): Serve the offline shell for short URLs + use no-cors for external resources (gatsbyjs#9679)
  chore(release): Publish
  fix: ensure babel-preset-gatsby can be used with unit tests (gatsbyjs#9629)
  feat(www): Filter posts by date (gatsbyjs#9400)
  fix(blog): azure blog post url date (gatsbyjs#9718)
  feat(blog): Add post on publishing to Azure (gatsbyjs#8868)
  Emphasize importance of promise return on source-plugin docs (gatsbyjs#9650)
  ...
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@imronras @gpetrioli
Fix grammar and punctuation (gatsbyjs#9498)
4ec4264 
- 'Building' to 'The building'
- 'in the past' to 'in the past,'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeskunall yeskunall yeskunall left review comments

@DSchau DSchau DSchau approved these changes

@shannonbux shannonbux shannonbux left review comments

Assignees
No one assigned
Labels
status: awaiting author response Additional information has been requested from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imronras @DSchau @yeskunall @shannonbux