Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prereleases Ionic branches #88

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Add prereleases Ionic branches #88

merged 3 commits into from
Aug 22, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 21, 2024

Enable prereleases in all Ionic branches (some main and some with stable ranches like gz-cmake4). The goal is to be able to use prereleases for the tutorial party but still keep nightlies to expedite iterating on existing PRs.

azeey added 3 commits August 21, 2024 13:56
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Copy link
Contributor Author

azeey commented Aug 21, 2024

I had to make the docopt changes to fix linting issues. pyright change behavior in handling the __doc__ parameter. From https://github.com/microsoft/pyright/releases/tag/1.1.372:

Changed the type of the doc attribute for a module to always be str | None. Previously, pyright changed its declared type to str if a docstring was present in the module, but this is incorrect because it's a writable value and can be set to None.

@azeey azeey requested a review from scpeters August 21, 2024 19:26
@scpeters
Copy link
Contributor

this looks ok; should we test it with ci_matching_branch/?

@scpeters
Copy link
Contributor

thanks for testing in gazebosim/gz-utils#137 !

@azeey azeey merged commit 40cddaf into master Aug 22, 2024
6 checks passed
@azeey azeey deleted the azeey/add_ionic_prereleases branch August 22, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants