Enable ign-launch main branch on Windows #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
j-rivero
reviewed
Jul 8, 2021
jenkins-scripts/dsl/ignition.dsl
Outdated
| @@ -639,7 +639,7 @@ ignition_software.each { ign_sw -> | |||
| ignition_win_ci_any_job.with | |||
| { | |||
| // ign-launch still not ported completely to Windows | |||
| if (ign_sw == 'launch') | |||
| if (ign_sw == 'launch' && branch != 'main') | |||
There was a problem hiding this comment.
There is no branch parameter in this look since -ci-pr_any- jobs does not deal with any particular branch generated by DSL. We can delete the whole condition and the disabled here.
10 tasks
Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
force-pushed
the
ahcorde/enable/win_launch
branch
from
bf81fc4 to
1bb1c2d
Compare
j-rivero
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started the port of ign-launch in Windows gazebosim/gz-launch#120, The PR is targeting the
mainbranch I enabled only this branchSigned-off-by: ahcorde ahcorde@gmail.com