Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying lens flare and camera distortion texture format #3005

Closed
audrow opened this issue May 20, 2021 · 0 comments · Fixed by #3007
Closed

Allow specifying lens flare and camera distortion texture format #3005

audrow opened this issue May 20, 2021 · 0 comments · Fixed by #3007
Assignees
@audrow
Labels
enhancement New feature or request

Comments

@audrow
Copy link
Contributor

audrow commented May 20, 2021 •
edited
Loading

Two possible solutions:

  • Change the hard-coded values from PF_A8R8G8B8 to PF_FLOAT32_RGBA. This will could impact performance for all users but is the easiest change.
  • Add an API for specifying the name of the compositor file in the lens flare and distortion classes. Then users can add their own compositor and change the pixel format as needed.
@audrow audrow added the enhancement New feature or request label May 20, 2021
@audrow audrow self-assigned this May 20, 2021
@audrow audrow mentioned this issue May 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@audrow audrow

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Distortion/LensFlarePlugin: set compositor names
1 participant
@audrow